The SAMATE Project Department of Homeland Security
Downloads:  Selected

Back to the previous page...Back to the previous page

Test Case IDCandidate2081
Bad / GoodBadBad test case
AuthorN/A
Associated test caseN/A
ContributorPaul E. Black
LanguageC
Type of test caseSource Code
Input string./a.out a234567890 b234567890XY
Expected Output final: XYa234567890b234567890XY>
InstructionsN/A
Submission date2009-04-03
DescriptioniconNo bounds checking on buffer during strcat(). PLOVER: BUFF.OVER This replaces case 1319
Filename
Flaw
  • (?) CWE-121: Stack-based Buffer Overflow at line 23

There is no comments :: Submit a comment :: RSS

>./strcat-bad1.c
  1. /*
  2.   PLOVER: BUFF.OVER
  3. */
  4.  
  5. /*
  6.         No bounds checking of strcat()
  8.     input: ./a.out a234567890 b234567890XY
  9. */
  10.  
  11. #include <stdio.h>
  12. #include <string.h>
  13.  
  14. #define MAXSIZE 20
  15.  
  16. void test(char *str, char *str2){
  17.     char pre[2] = "<";
  18.     char buf[MAXSIZE] = "";
  19.     char post[2] = ">";
  20.     if(strlen(str) < MAXSIZE)
  21.         strcpy(buf, str);
  22.     printf(" strcpy: %s%s%s\n", pre, buf, post);
  23.     strcat(buf, str2); // CWE-121
  24.     printf("results: %s%s%s\n", pre, buf, post);
  25. }
  26.  
  27. int main(int argc, char **argv){
  28.     char *userstr;
  29.     char *userstr2;
  30.     if(argc > 2){
  31.         userstr = argv[1];
  32.         userstr2 = argv[2];
  33.         test(userstr,userstr2);
  34.     }
  35.     printf("done\n");
  36.     return 0;
  37. }
  38.