Test case 250552

Type: source code
State: mixed
Author: NSA/Center for Assured Software
Status: accepted
Language: Java
Submission Date: 02 Nov 2017

Description

CWE: 191 Integer Underflow
BadSource: min Set data to the max value for byte
GoodSource: A hardcoded non-zero, non-min, non-max, even number
Sinks: sub
GoodSink: Ensure there will not be an underflow before subtracting 1 from data
BadSink : Subtract 1 from data, which can cause an Underflow
Flow Variant: 17 Control flow: for loops

Flaws

CWE-191 Integer Underflow (Wrap or Wraparound)

Test Suites

Documentation

Trace

- CWE191_Integer_Underflow__byte_min_predec_17.javaline 33
  - CWE-191 Integer Underflow (Wrap or Wraparound)
- CWE191_Integer_Underflow__byte_min_predec_17.javaline 38
  - CWE-191 Integer Underflow (Wrap or Wraparound)

Files

src

main

java

testcases

CWE191_Integer_Underflow

s05

CWE191_Integer_Underflow__byte_min_predec_17.java

testcasesupport

AbstractTestCase.java

AbstractTestCaseBase.java

IO.java

manifest.sarif


xxxxxxxxxx
99
 
1
/* TEMPLATE GENERATED TESTCASE FILE
2
Filename: CWE191_Integer_Underflow__byte_min_predec_17.java
3
Label Definition File: CWE191_Integer_Underflow.label.xml
4
Template File: sources-sinks-17.tmpl.java
5
*/
6
/*
7
* @description
8
* CWE: 191 Integer Underflow
9
* BadSource: min Set data to the max value for byte
10
* GoodSource: A hardcoded non-zero, non-min, non-max, even number
11
* Sinks: decrement
12
*    GoodSink: Ensure there will not be an underflow before decrementing data
13
*    BadSink : Decrement data, which can cause an Underflow
14
* Flow Variant: 17 Control flow: for loops
15
*
16
* */
17
18
package testcases.CWE191_Integer_Underflow.s05;
19
import testcasesupport.*;
20
21
public class CWE191_Integer_Underflow__byte_min_predec_17 extends AbstractTestCase
22
{
23
    public void bad() throws Throwable
24
    {
25
        byte data;
26
27
        /* We need to have one source outside of a for loop in order
28
         * to prevent the Java compiler from generating an error because
29
         * data is uninitialized
30
         */
31
32
        /* POTENTIAL FLAW: Use the maximum size of the data type */
33
        data = Byte.MIN_VALUE;
34
35
        for (int j = 0; j < 1; j++)
36
        {
37
            /* POTENTIAL FLAW: if data == Byte.MIN_VALUE, this will overflow */
38
            byte result = (byte)(--data);
39
            IO.writeLine("result: " + result);
40
        }
41
    }
42
43
    /* goodG2B() - use goodsource and badsink */
44
    private void goodG2B() throws Throwable
45
    {
46
        byte data;
47
48
        /* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */
49
        data = 2;
50
51
        for (int j = 0; j < 1; j++)
52
        {
53
            /* POTENTIAL FLAW: if data == Byte.MIN_VALUE, this will overflow */
54
            byte result = (byte)(--data);
55
            IO.writeLine("result: " + result);
56
        }
57
    }
58
59
    /* goodB2G() - use badsource and goodsink*/
60
    private void goodB2G() throws Throwable
61
    {
62
        byte data;
63
64
        /* POTENTIAL FLAW: Use the maximum size of the data type */
65
        data = Byte.MIN_VALUE;
66
67
        for (int k = 0; k < 1; k++)
68
        {
69
            /* FIX: Add a check to prevent an underflow from occurring */
70
            if (data > Byte.MIN_VALUE)
71
            {
72
                byte result = (byte)(--data);
73
                IO.writeLine("result: " + result);
74
            }
75
            else
76
            {
77
                IO.writeLine("data value is too small to decrement.");
78
            }
79
        }
80
    }
81
82
    public void good() throws Throwable
83
    {
84
        goodG2B();
85
        goodB2G();
86
    }
87
88
    /* Below is the main(). It is only used when building this testcase on
89
     * its own for testing or for building a binary to use in testing binary
90
     * analysis tools. It is not used when compiling all the testcases as one
91
     * application, which is how source code analysis tools are tested.
92
     */
93
    public static void main(String[] args) throws ClassNotFoundException,
94
           InstantiationException, IllegalAccessException
95
    {
96
        mainFromParent(args);
97
    }
98
}
99

Have any comments on this test case? Please, send us an email.