(/home/sate/Testcases/c/cve/wireshark-1.2.0/epan/dissectors/packet-dtpt.c) |
| |
| 314 | | | dissect_dtpt_sockaddr(tvbuff_t *tvb, guint offset, proto_tree *tree, int hfindex, int sockaddr_type) |
| 315 | | | { |
| 316 | | | guint32 sockaddr_length = 0; |
| 317 | | | proto_item *sockaddr_item = NULL; |
| 318 | | | proto_tree *sockaddr_tree = NULL; |
| 319 | | | guint32 sockaddr_len1 = 0; |
| 320 | | | guint32 sockaddr_len2 = 0; |
| 321 | | | |
| 322 | | | switch (sockaddr_type) { |
| 323 | | | case SOCKADDR_WITH_LEN: |
| 324 | | | sockaddr_len1=4; |
| 325 | | | sockaddr_len2=16; |
| 326 | | | break; |
| 327 | | | case SOCKADDR_CONNECT: |
| 328 | | | sockaddr_len1=0; |
Useless Assignment
This code assigns the variable the same value it already had. |
|
| 329 | | | sockaddr_len2=30; |
| 330 | | | break; |
| 331 | | | } |
| 332 | | | |
| 333 | | | if (sockaddr_type == SOCKADDR_WITH_LEN) |
| 334 | | | sockaddr_length = tvb_get_letohl(tvb, offset + 0); |
| 335 | | | |
| 336 | | | if (tree) { |
| 337 | | | sockaddr_item = proto_tree_add_text(tree, |
| 338 | | | tvb, offset, sockaddr_len1+sockaddr_len2, "%s", proto_registrar_get_name(hfindex)); |
| 339 | | | |
| 340 | | | if (sockaddr_item) |
| 341 | | | sockaddr_tree = proto_item_add_subtree(sockaddr_item, ett_dtpt_sockaddr); |
| 342 | | | if (sockaddr_tree) { |
| 343 | | | if (sockaddr_type == SOCKADDR_WITH_LEN) |
| 344 | | | proto_tree_add_uint(sockaddr_tree, hf_dtpt_sockaddr_length, |
| 345 | | | tvb, offset+0, 4, sockaddr_length); |
| 346 | | | } |
| 347 | | | } |
| 348 | | | |
| 349 | | | offset += sockaddr_len1; |
| 350 | | | |
| 351 | | | if (sockaddr_tree) { |
| 352 | | | switch (sockaddr_type) { |
| 353 | | | case SOCKADDR_WITH_LEN: { |
| 354 | | | guint16 family; |
| 355 | | | |
| 356 | | | family = tvb_get_letohs(tvb, offset); |
| 357 | | | proto_tree_add_uint(sockaddr_tree, hf_dtpt_sockaddr_family, |
| 358 | | | tvb, offset, 2, family); |
| 359 | | | switch (family) { |
| 360 | | | case WINSOCK_AF_INET: { |
| 361 | | | guint16 port; |
| 362 | | | guint32 addr; |
| 363 | | | |
| 364 | | | port = tvb_get_ntohs(tvb,offset+2); |
| 365 | | | proto_tree_add_uint(sockaddr_tree, hf_dtpt_sockaddr_port, |
| 366 | | | tvb, offset+2,2,port); |
| 367 | | | addr = tvb_get_ipv4(tvb,offset+4); |
| 368 | | | proto_tree_add_ipv4(sockaddr_tree, hf_dtpt_sockaddr_address, |
| 369 | | | tvb, offset+4,4,addr); |
| 370 | | | proto_tree_add_text(sockaddr_tree, tvb, offset+8, 8, "Padding"); |
| 371 | | | proto_item_append_text(sockaddr_item, ": %s:%d", ip_to_str((guint8*)&addr), port); |
| 372 | | | } |
| 373 | | | break; |
| 374 | | | } |
| 375 | | | } |
| 376 | | | break; |
| 377 | | | case SOCKADDR_CONNECT: { |
| 378 | | | guint32 family; |
| 379 | | | |
| 380 | | | family = tvb_get_letohl(tvb, offset+0); |
| 381 | | | proto_tree_add_uint(sockaddr_tree, hf_dtpt_sockaddr_family, |
| 382 | | | tvb, offset+0, 4, family); |
| 383 | | | switch (family) { |
| 384 | | | case WINSOCK_AF_INET: { |
| 385 | | | guint16 port; |
| 386 | | | guint32 addr; |
| 387 | | | |
| 388 | | | proto_tree_add_text(sockaddr_tree, tvb, offset+4, 4, "Padding"); |
| 389 | | | port = tvb_get_ntohs(tvb,offset+8); |
| 390 | | | proto_tree_add_uint(sockaddr_tree, hf_dtpt_sockaddr_port, |
| 391 | | | tvb, offset+8,2,port); |
| 392 | | | addr = tvb_get_ipv4(tvb,offset+10); |
| 393 | | | proto_tree_add_ipv4(sockaddr_tree, hf_dtpt_sockaddr_address, |
| 394 | | | tvb, offset+10,4,addr); |
| 395 | | | proto_tree_add_text(sockaddr_tree, tvb, offset+14, 16, "Padding"); |
| 396 | | | proto_item_append_text(sockaddr_item, ": %s:%d", ip_to_str((guint8*)&addr), port); |
| 397 | | | } |
| 398 | | | break; |
| 399 | | | } |
| 400 | | | } |
| 401 | | | break; |
| 402 | | | } |
| 403 | | | |
| 404 | | | } |
| 405 | | | offset += sockaddr_len2; |
| 406 | | | return offset; |
| 407 | | | } |
| |