Text   |  XML   |  ReML   |   Visible Warnings:

Redundant Condition  at tcap-persistentdata.c:848

No properties have been set. | edit properties
Jump to warning location ↓ warning details...
Show Events | Options

create_tcaphash_cont

(/home/sate/Testcases/c/cve/wireshark-1.2.0/epan/tcap-persistentdata.c)expand/collapse
Show more  
 828  static struct tcaphash_contcall_t *
 829  create_tcaphash_cont(struct tcaphash_cont_info_key_t *p_tcaphash_cont_key,
 830                       struct tcaphash_context_t *p_tcaphash_context)
 831  {
 832    struct tcaphash_contcall_t *p_tcaphash_contcall1 = NULL;
 833    struct tcaphash_contcall_t *p_tcaphash_contcall = NULL;
 834   
 835    p_tcaphash_contcall1 = (struct tcaphash_contcall_t *)
 836      g_hash_table_lookup(tcaphash_cont, p_tcaphash_cont_key);
 837   
 838    if (p_tcaphash_contcall1) {
 839      /* Walk through list of transaction with identical keys */
 840      /* go the the end to insert new record */
 841      do {
 842        if (!p_tcaphash_contcall1->next_contcall) {
 843          p_tcaphash_contcall=append_tcaphash_contcall(p_tcaphash_contcall1,
 844                                                       p_tcaphash_context);
 845          break;
 846        }
 847        p_tcaphash_contcall1 = p_tcaphash_contcall1->next_contcall;
 848      } while (p_tcaphash_contcall1 != NULL );
 849    } else {
 850      p_tcaphash_contcall = new_tcaphash_cont(p_tcaphash_cont_key,
 851                                              p_tcaphash_context);
 852    }
 853    return p_tcaphash_contcall;
 854  }
Show more  




Change Warning 1239.30748 : Redundant Condition

Priority:
State:
Finding:
Owner:
Note: