(/home/sate/Testcases/c/cve/wireshark-1.2.0/epan/dissectors/packet-edonkey.c) |
| |
| 1008 | | | static int dissect_kademlia_hash_hidden(tvbuff_t *tvb, packet_info *pinfo _U_, |
| 1009 | | | int offset, proto_tree *tree) { |
| 1010 | | | proto_item *hidden_item; |
| 1011 | | | char *hash = ep_alloc(33); |
| 1012 | | | char hash_part[9]; |
| 1013 | | | int i = 0; |
| 1014 | | | |
| 1015 | | | for (i=0; i<=12; i+=4) { |
Useless Assignment
This code assigns the variable the same value it already had. |
|
| 1016 | | | if (i == 0) |
| 1017 | | | g_snprintf(hash, 33, "%08X", tvb_get_letohl(tvb, offset)); |
| 1018 | | | else { |
| 1019 | | | g_snprintf(hash_part, sizeof(hash_part), "%08X", tvb_get_letohl(tvb, offset + i)); |
| 1020 | | | hash = g_strconcat(hash, hash_part, NULL); |
| 1021 | | | } |
| 1022 | | | } |
| 1023 | | | |
| 1024 | | | |
| 1025 | | | hidden_item = proto_tree_add_string_format_value(tree, hf_kademlia_hash, tvb, offset, 16, hash, "%s", hash); |
| 1026 | | | PROTO_ITEM_SET_HIDDEN(hidden_item);
x /home/sate/Testcases/c/cve/wireshark-1.2.0/epan/proto.h |
| |
319 | #define PROTO_ITEM_SET_HIDDEN(proto_item) \ |
320 | ((proto_item) ? FI_SET_FLAG((proto_item)->finfo, FI_HIDDEN) : 0) |
| |
x /home/sate/Testcases/c/cve/wireshark-1.2.0/epan/proto.h |
| |
246 | #define FI_SET_FLAG(fi, flag) (fi->flags = fi->flags | flag) |
| |
|
| 1027 | | | |
| 1028 | | | return offset+16; |
| 1029 | | | } |
| |