/* TEMPLATE GENERATED TESTCASE FILE Filename: CWE191_Integer_Underflow__short_min_predec_72b.java Label Definition File: CWE191_Integer_Underflow.label.xml Template File: sources-sinks-72b.tmpl.java */ /* * @description * CWE: 191 Integer Underflow * BadSource: min Set data to the max value for short * GoodSource: A hardcoded non-zero, non-min, non-max, even number * Sinks: decrement * GoodSink: Ensure there will not be an underflow before decrementing data * BadSink : Decrement data, which can cause an Underflow * Flow Variant: 72 Data flow: data passed in a Vector from one method to another in different source files in the same package * * */ package testcases.CWE191_Integer_Underflow.s05; import testcasesupport.*; import java.util.Vector; public class CWE191_Integer_Underflow__short_min_predec_72b { public void badSink(Vector dataVector ) throws Throwable { short data = dataVector.remove(2); /* POTENTIAL FLAW: if data == Short.MIN_VALUE, this will overflow */ short result = (short)(--data); IO.writeLine("result: " + result); } /* goodG2B() - use GoodSource and BadSink */ public void goodG2BSink(Vector dataVector ) throws Throwable { short data = dataVector.remove(2); /* POTENTIAL FLAW: if data == Short.MIN_VALUE, this will overflow */ short result = (short)(--data); IO.writeLine("result: " + result); } /* goodB2G() - use BadSource and GoodSink */ public void goodB2GSink(Vector dataVector ) throws Throwable { short data = dataVector.remove(2); /* FIX: Add a check to prevent an underflow from occurring */ if (data > Short.MIN_VALUE) { short result = (short)(--data); IO.writeLine("result: " + result); } else { IO.writeLine("data value is too small to decrement."); } } }